From dc6138076feccd14f18380f6cf16911b89b2058d Mon Sep 17 00:00:00 2001
From: Logan McNaughton <848146+loganmc10@users.noreply.github.com>
Date: Wed, 27 May 2026 14:23:43 +0200
Subject: [PATCH] use const for unknown name (#962)

---
 src/ui/android.rs | 2 +-
 src/ui/input.rs   | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/ui/android.rs b/src/ui/android.rs
index 2f8afdf..f5b49d3 100644
--- a/src/ui/android.rs
+++ b/src/ui/android.rs
@@ -392,7 +392,7 @@ fn list_controllers_on_jvm(env: &mut Env<'_>) -> jni::errors::Result<Vec<Control
         {
             name
         } else {
-            "Unknown controller".to_string()
+            ui::input::UNKNOWN_CONTROLLER_NAME.to_string()
         };
         let descriptor = if let Ok(product_id) = device.get_product_id(env)
             && let Ok(vendor_id) = device.get_vendor_id(env)
diff --git a/src/ui/input.rs b/src/ui/input.rs
index 1f90753..635716f 100644
--- a/src/ui/input.rs
+++ b/src/ui/input.rs
@@ -30,6 +30,8 @@ const MAX_AXIS_VALUE: f64 = 85.0;
 
 pub const DEADZONE_DEFAULT: i32 = 5;
 
+pub const UNKNOWN_CONTROLLER_NAME: &str = "Unknown controller";
+
 pub struct Controllers {
     pub rumble: bool,
     pub game_controller: *mut sdl3_sys::gamepad::SDL_Gamepad,
@@ -354,7 +356,7 @@ pub fn get_controller_names() -> Vec<String> {
         for joystick in get_joysticks().iter() {
             let name = unsafe { sdl3_sys::joystick::SDL_GetJoystickNameForID(*joystick) };
             controllers.push(if name.is_null() {
-                "Unknown controller".to_string()
+                UNKNOWN_CONTROLLER_NAME.to_string()
             } else {
                 unsafe { std::ffi::CStr::from_ptr(name).to_str().unwrap() }.to_string()
             });
@@ -1184,7 +1186,7 @@ pub fn init(ui: &mut ui::Ui) {
                     {
                         unsafe { std::ffi::CStr::from_ptr(name).to_str().unwrap() }.to_string()
                     } else {
-                        "Unknown controller".to_string()
+                        UNKNOWN_CONTROLLER_NAME.to_string()
                     };
 
                     let vendor_id =