This repository has been archived on 2026-08-27. You can view files and clone it, but cannot push or open issues or pull requests.
gopher64-netplay/src
Claude 98d9c6f0d0
Some checks failed
Rust / build-linux (linux-x86_64, X64, ubuntu-24.04, x86_64-unknown-linux-gnu) (pull_request) Failing after 8s
Rust / build-android (29.0.14206865, ubuntu-24.04, 33) (pull_request) Failing after 4s
Rust-lint / lint-linux (pull_request) Failing after 18s
Rust / build-linux (linux-aarch64, ARM64, ubuntu-24.04-arm, aarch64-unknown-linux-gnu) (pull_request) Has been cancelled
Rust / build-windows (windows-aarch64, woa64, windows-11-arm, aarch64-pc-windows-msvc) (pull_request) Has been cancelled
Rust / build-windows (windows-x86_64, win64, windows-2025, x86_64-pc-windows-msvc) (pull_request) Has been cancelled
Rust / build-macos (macos-aarch64, ARM64, aarch64-apple-darwin) (pull_request) Has been cancelled
Rust / Collect release artifacts (pull_request) Has been cancelled
Fix review findings: expose netplay callbacks on AppWindow, use rfd::AsyncFileDialog, set is_host on lobby update
Finding 1: the Rust side calls on_netplay_resume_session,
on_netplay_save_session and set_netplay_is_host on AppWindow, but the
callbacks/property were only declared on the NetplayCreate/NetplayWait
sub-components. appwindow.slint now declares callback
netplay_resume_session(string), callback netplay_save_session and the
in-out property netplay_is_host <=> NetplayWaitData.is_host, and
forwards them at the NetplayCreate/NetplayWait instantiation sites,
matching the existing netplay callback pattern.

Finding 2: rfd::AsyncFilePicker does not exist in rfd 0.17; the crate
exports AsyncFileDialog (already used by this repo in src/ui/gui.rs).
Switch the resume file picker to rfd::AsyncFileDialog and use
FileHandle::path() for the display path.

Finding 3: set is_host from the ResponseSession lobby update instead of
at wait-window open, comparing the local player name against players[0]
(the session creator, always registered first). Re-evaluates on every
lobby update.
2026-08-25 22:19:56 -05:00
..
compat Use upstream sse2neon (#694) 2026-03-28 19:24:53 +01:00
device fix libdragon interrupt issue (#1191) 2026-08-21 09:18:38 +00:00
ui Fix review findings: expose netplay callbacks on AppWindow, use rfd::AsyncFileDialog, set is_host on lobby update 2026-08-25 22:19:56 -05:00
cheats.rs Don't store luts in savestate (#993) 2026-05-31 06:37:11 +00:00
device.rs use tokio mutex (#1112) 2026-06-23 10:27:15 +00:00
lib.rs Add cli flag for widescreen (#1152) 2026-07-06 12:54:51 +00:00
main.rs put tokio runtime in dedicated thread (#1086) 2026-06-16 09:33:27 +00:00
netplay.rs move input polling (#1145) 2026-07-02 08:04:51 +00:00
retroachievements.rs put tokio runtime in dedicated thread (#1086) 2026-06-16 09:33:27 +00:00
savestates.rs add sleep while waiting for state (#1115) 2026-06-23 16:37:14 +00:00
ui.rs use rustls (#1194) 2026-08-24 12:35:05 +00:00