reviewer
ff5b4f32a9
ci: probe the Actions runner before writing the Rust gate
...
CI probe / probe (push) Successful in 1s
gopher64-netplay has no runnable gate (#23 ), blocking !10 !11 !15 !18 . The
build cannot run on the review box -- seven Rust worktrees took C: to 0.3%
free. Gitea 1.22.6's runner API endpoints 404, so runner availability, its
accepted labels, and its image contents are all unknown; this reports them
before the real SDL3/LLVM/submodule workflow is written against guesses.
2026-08-26 02:23:49 -05:00
3bdbcd0402
UI: session save/resume controls + resync status ( #8 )
Rust / build-linux (linux-x86_64, X64, ubuntu-24.04, x86_64-unknown-linux-gnu) (push) Failing after 5s
Rust / build-android (29.0.14206865, ubuntu-24.04, 33) (push) Failing after 4s
Rust-lint / lint-linux (push) Failing after 23s
Rust / build-linux (linux-aarch64, ARM64, ubuntu-24.04-arm, aarch64-unknown-linux-gnu) (push) Has been cancelled
Rust / build-windows (windows-aarch64, woa64, windows-11-arm, aarch64-pc-windows-msvc) (push) Has been cancelled
Rust / build-windows (windows-x86_64, win64, windows-2025, x86_64-pc-windows-msvc) (push) Has been cancelled
Rust / build-macos (macos-aarch64, ARM64, aarch64-apple-darwin) (push) Has been cancelled
Rust / Collect release artifacts (push) Has been cancelled
2026-08-26 09:14:17 +02:00
c5609be93a
netplay: state-message types for reliable channel protocol ( #1 )
Rust / build-linux (linux-aarch64, ARM64, ubuntu-24.04-arm, aarch64-unknown-linux-gnu) (push) Waiting to run
Rust / build-windows (windows-aarch64, woa64, windows-11-arm, aarch64-pc-windows-msvc) (push) Waiting to run
Rust / build-windows (windows-x86_64, win64, windows-2025, x86_64-pc-windows-msvc) (push) Waiting to run
Rust / build-macos (macos-aarch64, ARM64, aarch64-apple-darwin) (push) Waiting to run
Rust / Collect release artifacts (push) Blocked by required conditions
Rust / build-linux (linux-x86_64, X64, ubuntu-24.04, x86_64-unknown-linux-gnu) (push) Failing after 5s
Rust / build-android (29.0.14206865, ubuntu-24.04, 33) (push) Failing after 6s
Rust-lint / lint-linux (push) Failing after 28s
2026-08-26 08:45:24 +02:00
f0d0fc370f
ci(build): restore -C target-cpu=x86-64-v3 on published x86_64 builds ( #20 )
Rust / build-linux (linux-aarch64, ARM64, ubuntu-24.04-arm, aarch64-unknown-linux-gnu) (push) Waiting to run
Rust / build-windows (windows-aarch64, woa64, windows-11-arm, aarch64-pc-windows-msvc) (push) Waiting to run
Rust / build-windows (windows-x86_64, win64, windows-2025, x86_64-pc-windows-msvc) (push) Waiting to run
Rust / build-macos (macos-aarch64, ARM64, aarch64-apple-darwin) (push) Waiting to run
Rust / build-android (29.0.14206865, ubuntu-24.04, 33) (push) Waiting to run
Rust / Collect release artifacts (push) Blocked by required conditions
Rust-lint / lint-linux (push) Waiting to run
Rust / build-linux (linux-x86_64, X64, ubuntu-24.04, x86_64-unknown-linux-gnu) (push) Has been cancelled
2026-08-26 08:45:18 +02:00
82a4e2ba2f
Add .gitattributes: *.sh text eol=lf for Windows clones ( #19 )
Rust / build-linux (linux-aarch64, ARM64, ubuntu-24.04-arm, aarch64-unknown-linux-gnu) (push) Waiting to run
Rust / build-windows (windows-aarch64, woa64, windows-11-arm, aarch64-pc-windows-msvc) (push) Waiting to run
Rust / build-windows (windows-x86_64, win64, windows-2025, x86_64-pc-windows-msvc) (push) Waiting to run
Rust / build-macos (macos-aarch64, ARM64, aarch64-apple-darwin) (push) Waiting to run
Rust / build-android (29.0.14206865, ubuntu-24.04, 33) (push) Waiting to run
Rust / Collect release artifacts (push) Blocked by required conditions
Rust-lint / lint-linux (push) Waiting to run
Rust / build-linux (linux-x86_64, X64, ubuntu-24.04, x86_64-unknown-linux-gnu) (push) Has been cancelled
2026-08-26 08:45:14 +02:00
Claude
98d9c6f0d0
Fix review findings: expose netplay callbacks on AppWindow, use rfd::AsyncFileDialog, set is_host on lobby update
...
Rust / build-linux (linux-x86_64, X64, ubuntu-24.04, x86_64-unknown-linux-gnu) (pull_request) Failing after 8s
Rust / build-android (29.0.14206865, ubuntu-24.04, 33) (pull_request) Failing after 4s
Rust-lint / lint-linux (pull_request) Failing after 18s
Rust / build-linux (linux-aarch64, ARM64, ubuntu-24.04-arm, aarch64-unknown-linux-gnu) (pull_request) Has been cancelled
Rust / build-windows (windows-aarch64, woa64, windows-11-arm, aarch64-pc-windows-msvc) (pull_request) Has been cancelled
Rust / build-windows (windows-x86_64, win64, windows-2025, x86_64-pc-windows-msvc) (pull_request) Has been cancelled
Rust / build-macos (macos-aarch64, ARM64, aarch64-apple-darwin) (pull_request) Has been cancelled
Rust / Collect release artifacts (pull_request) Has been cancelled
Finding 1: the Rust side calls on_netplay_resume_session,
on_netplay_save_session and set_netplay_is_host on AppWindow, but the
callbacks/property were only declared on the NetplayCreate/NetplayWait
sub-components. appwindow.slint now declares callback
netplay_resume_session(string), callback netplay_save_session and the
in-out property netplay_is_host <=> NetplayWaitData.is_host, and
forwards them at the NetplayCreate/NetplayWait instantiation sites,
matching the existing netplay callback pattern.
Finding 2: rfd::AsyncFilePicker does not exist in rfd 0.17; the crate
exports AsyncFileDialog (already used by this repo in src/ui/gui.rs).
Switch the resume file picker to rfd::AsyncFileDialog and use
FileHandle::path() for the display path.
Finding 3: set is_host from the ResponseSession lobby update instead of
at wait-window open, comparing the local player name against players[0]
(the session creator, always registered first). Re-evaluates on every
lobby update.
2026-08-25 22:19:56 -05:00
Claude
8e2c29039c
UI: session save/resume controls + resync status ( #8 )
...
Add UI controls for the netplay session save/resume and resync
indicator features:
- netplay_create.slint: Add 'Resume Session...' button with file picker
callback for .netplay-state files
- netplay_wait.slint: Add 'Save Session' button (host only, gated by
is_host property), add resyncing indicator badge
- netplay_page.slint: Add resyncing property to NetplayData global
- src/ui/netplay.rs: Wire on_netplay_resume_session callback (opens
file picker, placeholder for #3 flow), on_netplay_save_session
callback (placeholder for #3 flow), set is_host on wait window setup
The save/resume callbacks show placeholder messages until #3 is
implemented. The resync indicator shows during ResyncState != Idle.
Closes #8
2026-08-25 22:19:56 -05:00
Hermes CI
f56f42a3e8
ci(build): restore -C target-cpu=x86-64-v3 on published x86_64 builds
...
Rust / build-linux (linux-x86_64, X64, ubuntu-24.04, x86_64-unknown-linux-gnu) (pull_request) Failing after 4s
Rust / build-android (29.0.14206865, ubuntu-24.04, 33) (pull_request) Failing after 3s
Rust-lint / lint-linux (pull_request) Failing after 15s
Rust / build-linux (linux-aarch64, ARM64, ubuntu-24.04-arm, aarch64-unknown-linux-gnu) (pull_request) Has been cancelled
Rust / build-windows (windows-aarch64, woa64, windows-11-arm, aarch64-pc-windows-msvc) (pull_request) Has been cancelled
Rust / build-windows (windows-x86_64, win64, windows-2025, x86_64-pc-windows-msvc) (pull_request) Has been cancelled
Rust / build-macos (macos-aarch64, ARM64, aarch64-apple-darwin) (pull_request) Has been cancelled
Rust / Collect release artifacts (pull_request) Has been cancelled
Issue #20 : !17 (#16 ) made the x86-64-v3 baseline opt-in via RUSTFLAGS but
nothing set it, so release binaries silently fell back to the plain x86-64
baseline. Set RUSTFLAGS per matrix row on the two x86_64 entries only:
- linux x86_64-unknown-linux-gnu: -C target-cpu=x86-64-v3
- windows x86_64-pc-windows-msvc: -C target-cpu=x86-64-v3
-C link-arg=/STACK:8388608 (carries the 8 MB stack link-arg that the
repo config supplies for Windows, because RUSTFLAGS REPLACES config
rustflags rather than appending)
The aarch64 rows keep the config's link-args untouched (no RUSTFLAGS at
all), and macOS / android jobs plus .cargo/config.toml are unchanged.
Closes #20
2026-08-25 21:52:44 -05:00
Claude
cfa469428c
Add .gitattributes: *.sh text eol=lf for Windows clones
...
Rust / build-linux (linux-x86_64, X64, ubuntu-24.04, x86_64-unknown-linux-gnu) (pull_request) Failing after 4s
Rust / build-android (29.0.14206865, ubuntu-24.04, 33) (pull_request) Failing after 4s
Rust-lint / lint-linux (pull_request) Failing after 16s
Rust / build-linux (linux-aarch64, ARM64, ubuntu-24.04-arm, aarch64-unknown-linux-gnu) (pull_request) Has been cancelled
Rust / build-windows (windows-aarch64, woa64, windows-11-arm, aarch64-pc-windows-msvc) (pull_request) Has been cancelled
Rust / build-windows (windows-x86_64, win64, windows-2025, x86_64-pc-windows-msvc) (pull_request) Has been cancelled
Rust / build-macos (macos-aarch64, ARM64, aarch64-apple-darwin) (pull_request) Has been cancelled
Rust / Collect release artifacts (pull_request) Has been cancelled
Windows clones default to core.autocrlf=true, which checks out CRLF into
*.sh working copies even though the committed blobs are byte-clean. The
shebang then dies with "env: 'bash\r': No such file or directory"
(exit 127), which read like a broken script rather than a line-ending
artifact. Assert LF for all shell scripts at the repo root so every
Windows clone gets clean scripts/gate.sh, data/icon/generate.sh and
data/shader/output.sh.
Closes #19
2026-08-25 21:44:25 -05:00
8a46ac58a2
Runnable build gate on the review box: portable config + documented gate script ( #16 )
Rust / build-linux (linux-aarch64, ARM64, ubuntu-24.04-arm, aarch64-unknown-linux-gnu) (push) Waiting to run
Rust / build-windows (windows-aarch64, woa64, windows-11-arm, aarch64-pc-windows-msvc) (push) Waiting to run
Rust / build-windows (windows-x86_64, win64, windows-2025, x86_64-pc-windows-msvc) (push) Waiting to run
Rust / build-macos (macos-aarch64, ARM64, aarch64-apple-darwin) (push) Waiting to run
Rust / Collect release artifacts (push) Blocked by required conditions
Rust / build-linux (linux-x86_64, X64, ubuntu-24.04, x86_64-unknown-linux-gnu) (push) Failing after 7s
Rust / build-android (29.0.14206865, ubuntu-24.04, 33) (push) Failing after 4s
Rust-lint / lint-linux (push) Failing after 23s
2026-08-26 04:39:46 +02:00
pbwraith-worker
800495c912
fix( #16 ): wire provisioned cmake lib root + link/run tests in the gate (review bounce)
...
Rust / build-linux (linux-x86_64, X64, ubuntu-24.04, x86_64-unknown-linux-gnu) (pull_request) Failing after 8s
Rust / build-android (29.0.14206865, ubuntu-24.04, 33) (pull_request) Failing after 5s
Rust-lint / lint-linux (pull_request) Failing after 21s
Rust / build-linux (linux-aarch64, ARM64, ubuntu-24.04-arm, aarch64-unknown-linux-gnu) (pull_request) Has been cancelled
Rust / build-windows (windows-aarch64, woa64, windows-11-arm, aarch64-pc-windows-msvc) (pull_request) Has been cancelled
Rust / build-windows (windows-x86_64, win64, windows-2025, x86_64-pc-windows-msvc) (pull_request) Has been cancelled
Rust / build-macos (macos-aarch64, ARM64, aarch64-apple-darwin) (pull_request) Has been cancelled
Rust / Collect release artifacts (pull_request) Has been cancelled
Review findings addressed (PR #17 bounce):
1. gate.sh put the provisioned cmake/ninja on PATH but never added their
OWN lib root to LD_LIBRARY_PATH, so cmake died with exit 127
(librhash.so.0 / libuv.so.1 / libjsoncpp.so.25 not found) and cmake-rs
misreported 'is cmake not installed?'. The LLVM_BIN2 block now exports
LD_LIBRARY_PATH=~/local-tools/root/usr/lib/x86_64-linux-gnu (same
append pattern as the other two roots; final value carries all three).
2. The gate was compile-only. It now runs three steps: cargo check
--all-targets (type-check), cargo test --no-run (LINK every test
binary), cargo test --lib (EXECUTE headless lib unit tests).
3. docs/build-gate.md: prerequisites list the provisioned cmake's
shared-lib root, the test-execution decision record, and the new
troubleshooting entry.
Verified on the review box: cold full gate exits 0 (GATE_OK), step 1
check then 11m52s test-link codegen then 'running 0 tests / ok' (main has
no #[test] fns yet; the inbound netplay PRs add ~38); warm re-run 5.6s.
2026-08-25 16:21:01 -05:00
Claude
c30bb32bf9
gopher64-netplay#16: runnable build gate on the review box
...
Two blockers fixed in .cargo/config.toml plus a documented gate script:
- target-cpu=x86-64-v3 (AVX2-only) is now opt-in — the default build is
portable; on Sandy Bridge (x86-64-v2) it miscompiled build scripts
(num-traits SIGABRT, 648518346341351440-byte allocation).
- AR=llvm-ar dropped (GNU ar is fine); CC=clang/CXX=clang++ retained
because build.rs needs clang for -flto=thin, resolved via PATH.
scripts/gate.sh records the review-box command: init submodules, wire the
user-local LLVM-18 / pkgconf / fontconfig-X11 roots (no sudo available),
then cargo check --all-targets. docs/build-gate.md explains the failure
modes. Verified: ./scripts/gate.sh exits 0 end-to-end on this box.
2026-08-25 16:21:01 -05:00
Hermes CI
0374eb765d
ci: pin actions/checkout to v4 (node20) — v7 needs node24, unsupported by host runner
Rust / build-linux (linux-aarch64, ARM64, ubuntu-24.04-arm, aarch64-unknown-linux-gnu) (push) Waiting to run
Rust / build-windows (windows-aarch64, woa64, windows-11-arm, aarch64-pc-windows-msvc) (push) Waiting to run
Rust / build-windows (windows-x86_64, win64, windows-2025, x86_64-pc-windows-msvc) (push) Waiting to run
Rust / build-macos (macos-aarch64, ARM64, aarch64-apple-darwin) (push) Waiting to run
Rust / Collect release artifacts (push) Blocked by required conditions
Rust / build-linux (linux-x86_64, X64, ubuntu-24.04, x86_64-unknown-linux-gnu) (push) Failing after 56s
Rust / build-android (29.0.14206865, ubuntu-24.04, 33) (push) Failing after 12s
Rust-lint / lint-linux (push) Failing after 45s
Security audit / audit (push) Failing after 7m8s
2026-08-25 22:18:33 +02:00
Claude
891d12c08a
netplay: add state-message types to reliable channel protocol ( #1 )
...
Rust-lint / lint-linux (pull_request) Failing after 1s
Rust / build-linux (linux-x86_64, X64, ubuntu-24.04, x86_64-unknown-linux-gnu) (pull_request) Failing after 1s
Rust / build-android (29.0.14206865, ubuntu-24.04, 33) (pull_request) Failing after 1s
Rust / build-linux (linux-aarch64, ARM64, ubuntu-24.04-arm, aarch64-unknown-linux-gnu) (pull_request) Has been cancelled
Rust / build-windows (windows-aarch64, woa64, windows-11-arm, aarch64-pc-windows-msvc) (pull_request) Has been cancelled
Rust / build-windows (windows-x86_64, win64, windows-2025, x86_64-pc-windows-msvc) (pull_request) Has been cancelled
Rust / build-macos (macos-aarch64, ARM64, aarch64-apple-darwin) (pull_request) Has been cancelled
Rust / Collect release artifacts (pull_request) Has been cancelled
Add message-name constants and reliable-channel helpers for netplay
session state transfer:
- Message-name constants: netplay_state, netplay_state_ready,
resync_state, resync_ready
- Chunked message codec (encode_message_chunks / decode_message /
decode_packets) reusing the existing 16 KiB reliable-channel
transport; send_message/process_reliable_messages refactored onto it
- send_netplay_state / receive_netplay_state for full session state
- send_ready / wait_for_ready ack helpers (10s timeout, same pattern
as receive_message); receive_message extracted to wait_for_message
with preserve of input_delay/disconnect side effects
- Large payloads (>1MB) accumulate into incoming_message until a full
postcard message parses
- Unit tests: 5MB payload round-trip through the chunked codec, ack
send/receive within timeout, missing ack times out with the standard
panic pattern
Closes #1
2026-08-25 02:34:07 -05:00
Claude
00f918e127
Import gopher64 upstream
Rust / build-linux (linux-aarch64, ARM64, ubuntu-24.04-arm, aarch64-unknown-linux-gnu) (push) Waiting to run
Rust / build-windows (windows-aarch64, woa64, windows-11-arm, aarch64-pc-windows-msvc) (push) Waiting to run
Rust / build-windows (windows-x86_64, win64, windows-2025, x86_64-pc-windows-msvc) (push) Waiting to run
Rust / build-macos (macos-aarch64, ARM64, aarch64-apple-darwin) (push) Waiting to run
Rust / Collect release artifacts (push) Blocked by required conditions
Rust-lint / lint-linux (push) Failing after 16s
Rust / build-linux (linux-x86_64, X64, ubuntu-24.04, x86_64-unknown-linux-gnu) (push) Failing after 2s
Rust / build-android (29.0.14206865, ubuntu-24.04, 33) (push) Failing after 1s
2026-08-24 23:01:43 -05:00
3b0cd9e0b6
Initial commit
2026-08-25 06:01:30 +02:00
Logan McNaughton
42c44998ff
update quick-xml ( #1195 )
2026-08-24 13:10:50 +00:00
Logan McNaughton
1957e8a579
use rustls ( #1194 )
...
* use rustls
* more
* more
* more
* more
* more
2026-08-24 12:35:05 +00:00
Logan McNaughton
aac8572ee8
bump ver ( #1192 )
2026-08-21 09:41:11 +00:00
Logan McNaughton
d078c66469
fix libdragon interrupt issue ( #1191 )
2026-08-21 09:18:38 +00:00
Logan McNaughton
01ad4b5fe4
update rust ( #1190 )
2026-08-20 18:39:19 +00:00
Logan McNaughton
60582608f1
add VRU word for pirate-sword ( #1188 )
2026-08-19 13:58:20 +00:00
Logan McNaughton
c2b64adbc7
remove rumble flag, just try to rumble ( #1185 )
2026-08-12 19:34:42 +00:00
Logan McNaughton
efe78e544a
fix some clippy warnings ( #1181 )
2026-08-06 23:00:08 +00:00
Logan McNaughton
05fe5b2995
cargo update ( #1180 )
2026-08-06 14:14:49 +00:00
Logan McNaughton
e9b0915b87
add instructions for input profile ( #1179 )
...
* add instructions for input profile
* update translation files
* update translations
2026-08-03 15:43:27 +00:00
Logan McNaughton
7b17343c72
update netplay id ( #1171 )
2026-08-03 14:11:57 +00:00
Logan McNaughton
bfab42eccd
update rcheevos ( #1172 )
2026-07-23 22:11:01 +00:00
Logan McNaughton
6bb3487352
use obfstr ( #1168 )
...
* use obfstr
* more
2026-07-20 14:30:23 +00:00
Logan McNaughton
c38ae12f0a
update rust ( #1167 )
...
* update rust
* remove cache
* more
2026-07-20 08:49:16 +00:00
Logan McNaughton
f113923748
fix spinbox height ( #1160 )
...
* fix spinbox height
* more
2026-07-14 07:07:47 +00:00
Logan McNaughton
67b8f472b3
Remove DRI_PRIME ( #1159 )
...
Not needed with Vulkan
2026-07-13 10:28:02 +00:00
Logan McNaughton
282ec6c6c7
add gpu hints on windows ( #1158 )
2026-07-13 07:17:35 +00:00
Logan McNaughton
81cc78ce90
bump crate and rust versions ( #1155 )
2026-07-09 13:06:49 +00:00
PolygonPrincess
e8a7abffe3
Add cli flag for widescreen ( #1152 )
...
* Add cli flag for widescreen and enable config fallback
* Fix else statement brace spacing and trailing whitespace
* Fix trailing whitespace within args.widescreen else statement
2026-07-06 12:54:51 +00:00
dependabot[bot]
f7ad6a4b0d
Bump rust-toolchain from 1.96.0 to 1.96.1 ( #1151 )
...
Bumps [rust-toolchain](https://github.com/rust-lang/rust ) from 1.96.0 to 1.96.1.
- [Release notes](https://github.com/rust-lang/rust/releases )
- [Changelog](https://github.com/rust-lang/rust/blob/main/RELEASES.md )
- [Commits](https://github.com/rust-lang/rust/compare/1.96.0...1.96.1 )
---
updated-dependencies:
- dependency-name: rust-toolchain
dependency-version: 1.96.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-07-06 04:34:17 +00:00
Logan McNaughton
1bfb50de8a
re-arrange input profiles ( #1150 )
2026-07-05 10:43:23 +00:00
Logan McNaughton
3bc7c96191
move input polling ( #1145 )
...
* move input polling
* more
* more
* more
2026-07-02 08:04:51 +00:00
Logan McNaughton
032bf1acf3
Update contribution guidelines ( #1143 )
2026-07-01 07:58:17 +00:00
Logan McNaughton
8bc765c1a3
match RA branding softcore->casual ( #1142 )
2026-07-01 07:34:48 +00:00
Logan McNaughton
da061240af
normalize no-intro names ( #1139 )
2026-06-30 10:32:43 +00:00
Logan McNaughton
407a1b967c
Re-arrange settings ( #1138 )
...
* update setting locations
* tra
2026-06-30 09:53:03 +00:00
999sian
ad756cd6bd
settings: add a dark/light theme toggle ( #1132 )
...
* settings: add dark/light theme toggle
* i18n: translate theme selector strings
* settings: align Resolution and Theme dropdowns in a GridBox
2026-06-30 09:17:12 +00:00
Logan McNaughton
6e11bc18d6
translation tweaks ( #1137 )
2026-06-30 05:24:48 +00:00
Logan McNaughton
c8eee9f727
don't copy from db ( #1136 )
2026-06-30 05:23:38 +00:00
Logan McNaughton
01a53ce1c0
use no-intro names in netplay/cheats ( #1133 )
...
* use no-intro names in netplay/cheats
* more
* more
2026-06-29 19:37:33 +00:00
Logan McNaughton
0eddf31f92
update contributing guidelines ( #1130 )
2026-06-29 09:53:00 +00:00
Logan McNaughton
e257ba717b
update ggrs ( #1127 )
2026-06-27 08:19:14 +00:00
Logan McNaughton
7a797165fd
Fix translation for 'Open Saves Folder' in Portuguese ( #1125 )
2026-06-26 07:23:50 +00:00
Logan McNaughton
a659413090
bump ver ( #1124 )
2026-06-25 13:09:55 +00:00